-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a couple of issues #74
Comments
Thanks for reporting these issues!
|
both of the issues are solved on my branch yes, as for does it work https://marketplace.visualstudio.com/items?itemName=ctf0.htmlhint the installation count says it all especially that this is all what i've added |
Any work on this? I'm trying to validate some html inside markdown documents. I think that the: "activationEvents": [
"onFileSystem:file"
], is needed so the extension can be activated for other files than HTML (so it can be used for markdown files if I specify The other change I can see is the addition of: "htmlhint.documentSelector": {
"items": {
"type": "string"
}
} that I don't know if it is really necessary. |
@coliff For the In interface Settings {
htmlhint: {
enable: boolean;
options: any;
optionsFile: string;
},
[key: string]: any;
} and the code to load the configuration if the option is specified inside else if (settings.htmlhint && settings.htmlhint.optionsFile) {
options = loadConfigurationFile(settings.htmlhint.optionsFile)
} |
sorry for the delay on this... I'd been testing that change locally and hope to get an update with this change out soon. thanks! |
the
"htmlhint.documentSelector
wont work because ofvscode-htmlhint/htmlhint/package.json
Line 32 in 07db8b2
htmlhint.configFile
isnt availablevscode-htmlhint/htmlhint/package.json
Line 39 in 07db8b2
REF:
https://github.com/htmlhint/vscode-htmlhint/tree/main/htmlhint#settings
The text was updated successfully, but these errors were encountered: