fixed some oversights from #48

[codemasher]

You might want to merge this before tagging 2.0

[shadowhand]

Thanks!

[codemasher]

Hi uh can we please have a new version tagged finally?

[shadowhand]

Version 2.1.0 tagged.

[shadowhand]

Also, please check the attitude. This is an open source project and I don't owe you anything. Please be respectful.

[codemasher]

I spent several hours of work in this PR/project and waited literal years to finally get it merged and you went radio silent immediately after it instead of tagging a release countless people were waiting for. But it's my "attitude" for asking. Right, got it.

[shadowhand]

@codemasher I'm going to break this down, since it didn't sink in the first time around...

I spent several hours of work in this PR/project

Your work is appreciated. I have also spent hours of work on this project, including the multitude of hours I spent working with PHP-FIG to get PSR-17 published.

and waited literal years to finally get it merged

Again, this open source. I am not paid to do this. The implication you are making is that you are entitled to something from me. Unless you are going to support this project by paying me for my time, I owe you absolutely nothing.

and you went radio silent immediately after it

Factually untrue. Version 2.0.0 was tagged after #47, and (AFAICT) there are no functional changes between 2.0 and 2.1, so there was little urgency on my part. (And again, see above.)

instead of tagging a release countless people were waiting for.

No one else has commented or reacted to indicate they were waiting for these changes to be tagged. So the number of people waiting is very countable: one.

But it's my "attitude" for asking. Right, got it.

It has nothing to do with asking and everything to do with how you asked. When you ask in an entitled, petulant way I am absolutely going to call that out. And rather than apologizing, or thanking me, or even saying nothing at all, you doubled down with this childish response. 🙄

Please be more mindful of how you talk to others who are giving their time for your benefit.