Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same name needed for the Github repo and the npm package #1345

Open
sylque opened this issue Jun 6, 2019 · 8 comments
Open

Same name needed for the Github repo and the npm package #1345

sylque opened this issue Jun 6, 2019 · 8 comments

Comments

@sylque
Copy link

sylque commented Jun 6, 2019

It's the third time I install by mistake the npm package called node-http-proxy, which is a different package. Would it be possible to have the same name for both the npm package and the repo? It is very confusing.

@shirshak55
Copy link

yea github name should be changed. Its so weird to have different name. And seems like repo is not maintained so probably we should fork it with promise support and typescript. This seems so outdated.

@MartinMuzatko
Copy link

MartinMuzatko commented Jun 19, 2019

There are even packages that reverse this behavior :P
https://www.npmjs.com/package/node-docker-api -> https://github.com/AgustinCB/docker-api

Honestly, the only good reason to have node in the name of the project is to make links to this repo more appearent that they are build on top of node. But since a quick glance into the readme also reveals that, the prefix should be omitted.

@shirshak55
Copy link

@MartinMuzatko yea I think now it is not necessary to change :) May be we can alias in npm. In github writing node will help to identify it is node based project 👍

@Falieson
Copy link

@shirshak55 99% of the time I'd agree with you "node- " helps identify the project, but the organization is "nodejitsu" :-/
Real shame this package is unmaintained

@jsmylnycky
Copy link
Contributor

Hello!

Since there is no "standard" in naming conventions, I'll be closing this ticket with no action taken. We also are no longer maintained by nodejitsu as an org, so there is less implication as to the tech stack.

Please note that we're adding more active maintainers and will be looking to inject new life into this project over the coming months and into the future :)

If you're interested in helping out, please see the current pinned issue #1354

@sylque
Copy link
Author

sylque commented Aug 26, 2019

@jsmylnycky , I'm not sure you got the point here, so please let me rephrase:

  • This Github repository - which I think is the main entry point for developers - is called http-party/node-http-proxy.
  • I believe most developers returning to this package will do the same mistake I've done twice: they won't read the documentation (because they think they now) and will type npm install node-http-proxy --save (notice the wrong npm package name, the correct one being http-proxy).
  • Unfortunately, the above mistake won't trigger any error, because there is a npm package called node-http-proxy! The time they realize they've installed the wrong package and cleanup the mess, they'll have lost 15 minutes.

So what is needed here is to have the same name for the Github repo and the npm package.

@sylque sylque changed the title Please rename this repo from node-http-proxy to http-proxy Same name needed for the Github repo and the npm package Aug 26, 2019
@jsmylnycky
Copy link
Contributor

@sylque When you put it the way you just did, I completely get your argument and am in agreement.

I'll reopen and draw attention from @jcrugzz and @indexzero . I'm still new to the maintenance of this project so I'd prefer if one of the veterans signs off on something as drastic as a repo name change. :)

@jsmylnycky jsmylnycky reopened this Aug 26, 2019
@hcldan
Copy link

hcldan commented Jan 19, 2022

I believe most developers returning to this package will do the same mistake I've done twice: they won't read the documentation (because they think they now) and will type npm install node-http-proxy --save (notice the wrong npm package name, the correct one being http-proxy).

I'm so glad this ticket exists (as I was searching for if this project was maintained). I did the exact same thing, and thought it was odd there were so many security vulnerabilities listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants