Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README examples has wrong listening port numbers #969

Closed
subomi opened this issue Feb 27, 2016 · 1 comment
Closed

README examples has wrong listening port numbers #969

subomi opened this issue Feb 27, 2016 · 1 comment

Comments

@subomi
Copy link
Contributor

subomi commented Feb 27, 2016

In section Setup a stand-alone proxy server with custom server logic:
We have:
`var server = http.createServer(function(req, res) {
// You can define here your custom logic to handle the request
// and then proxy the request.
proxy.web(req, res, { target: 'http://127.0.0.1:5060' });
});

console.log("listening on port 5050")
server.listen(5050);`

Instead of:
`var server = http.createServer(function(req, res) {
// You can define here your custom logic to handle the request
// and then proxy the request.
proxy.web(req, res, { target: 'http://127.0.0.1:5050' });
});

console.log("listening on port 5050")
server.listen(5050)'

And also the same thing in section Setup a stand-alone proxy server with proxy request header re-writing

subomi added a commit to subomi/node-http-proxy that referenced this issue Feb 28, 2016
There were errors in the examples highlighted, check issue http-party#969
indexzero pushed a commit that referenced this issue Aug 22, 2019
There were errors in the examples highlighted, check issue #969
@indexzero
Copy link
Contributor

Fixed in #970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants