From ddb36025d92c280647cc6fe9fbe18337f22baff0 Mon Sep 17 00:00:00 2001 From: Nick Gilligan Date: Mon, 22 Oct 2018 15:30:17 -0700 Subject: [PATCH] fix 'Modify Response' readme section to avoid unnecessary array copying --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index ea73dca31..5acc4a69f 100644 --- a/README.md +++ b/README.md @@ -501,12 +501,12 @@ data. selfHandleResponse : true }; proxy.on('proxyRes', function (proxyRes, req, res) { - var body = new Buffer(''); - proxyRes.on('data', function (data) { - body = Buffer.concat([body, data]); + var body = []; + proxyRes.on('data', function (chunk) { + body.push(chunk); }); proxyRes.on('end', function () { - body = body.toString(); + body = Buffer.concat(body).toString(); console.log("res from proxied server:", body); res.end("my response to cli"); });