Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: http-party/node-portfinder
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.25
Choose a base ref
...
head repository: http-party/node-portfinder
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.26
Choose a head ref
  • 5 commits
  • 5 files changed
  • 3 contributors

Commits on Oct 24, 2019

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    479a8e2 View commit details
  2. Merge pull request #96 from kwiatkk1/repo_url_links_updated

    #94: update links after repo moved to a new org
    eriktrom authored Oct 24, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    crazy-max CrazyMax
    Copy the full SHA
    cd08663 View commit details

Commits on Apr 10, 2020

  1. mkdirp: 0.5.5

    Update `mkdirp` to 0.5.5 which in turn updates `minimist` to 1.2.5
    which addresses:
    
        https://www.npmjs.com/advisories/1179
    msbit committed Apr 10, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    891ba80 View commit details

Commits on Apr 28, 2020

  1. Merge pull request #101 from msbit/mkdirp-0.5.5

    mkdirp: 0.5.5
    eriktrom authored Apr 28, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e40deb2 View commit details
  2. 1.0.26

    eriktrom committed Apr 28, 2020
    Copy the full SHA
    3709e43 View commit details
Showing with 13 additions and 13 deletions.
  1. +1 −1 lib/portfinder.js
  2. +8 −8 package-lock.json
  3. +2 −2 package.json
  4. +1 −1 test/port-finder-test.js
  5. +1 −1 test/port-finder-z-integration-test.js
2 changes: 1 addition & 1 deletion lib/portfinder.js
Original file line number Diff line number Diff line change
@@ -467,7 +467,7 @@ exports._defaultHosts = (function() {
// - https://github.com/Microsoft/BashOnWindows/issues/468
//
// - Workaround is a mix of good work from the community:
// - https://github.com/indexzero/node-portfinder/commit/8d7e30a648ff5034186551fa8a6652669dec2f2f
// - https://github.com/http-party/node-portfinder/commit/8d7e30a648ff5034186551fa8a6652669dec2f2f
// - https://github.com/yarnpkg/yarn/pull/772/files
if (e.syscall === 'uv_interface_addresses') {
// swallow error because we're just going to use defaults
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "portfinder",
"description": "A simple tool to find an open port on the current machine",
"version": "1.0.25",
"version": "1.0.26",
"author": "Charlie Robbins <charlie.robbins@gmail.com>",
"repository": {
"type": "git",
"url": "git@github.com:indexzero/node-portfinder.git"
"url": "git@github.com:http-party/node-portfinder.git"
},
"keywords": [
"http",
2 changes: 1 addition & 1 deletion test/port-finder-test.js
Original file line number Diff line number Diff line change
@@ -168,7 +168,7 @@ vows.describe('portfinder').addBatch({
}
}).addBatch({
"When using portfinder module": {
// regression test for indexzero/node-portfinder#65
// regression test for http-party/node-portfinder#65
"the getPort() method with startPort less than or equal to 80": {
topic: function () {
portfinder.getPort({startPort: 80}, this.callback);
2 changes: 1 addition & 1 deletion test/port-finder-z-integration-test.js
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ hence the 'z' in the name of this file).
/*
* port-finder-0-vs-127-test.js: Test for the `portfinder` module.
* that demonstrates issue #24
* https://github.com/indexzero/node-portfinder/issues/24
* https://github.com/http-party/node-portfinder/issues/24
*/

var vows = require('vows'),