Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move trailers submodule to transfer #300

Open
yoshuawuyts opened this issue Dec 18, 2020 · 2 comments · May be fixed by #309
Open

Move trailers submodule to transfer #300

yoshuawuyts opened this issue Dec 18, 2020 · 2 comments · May be fixed by #309
Labels
semver-major This change requires a semver major change
Milestone
3.0

Comments

@yoshuawuyts
Copy link
Member

Trailers should be grouped together with TE and Transfer-Encoding headers.
@yoshuawuyts yoshuawuyts added the semver-major This change requires a semver major change label Dec 18, 2020
@yoshuawuyts yoshuawuyts added this to the 3.0 milestone Dec 18, 2020
@brightly-salty
Copy link
Contributor

I'm willing to attempt to implement this and submit a PR. Do you want the path to Trailers to be crate::transfer::Trailers or crate::transfer::trailers::Trailers? I think it would be best to base it off of my remove-reexports branch (PR #305 )

@brightly-salty
Copy link
Contributor

Never mind, I'll base it off of the transfer branch.

@brightly-salty brightly-salty linked a pull request Dec 19, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-major This change requires a semver major change
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Make trailers module a submodle of transfer brightly-salty/http-types
2 participants
@yoshuawuyts @brightly-salty