-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-Suite is broken #166
Comments
Thanks a lot. I think we're fine with custom mock server over real sockets on localhost for now. Files you are patching are no longer used, please see |
Thanks for your quick reply! Yeah... I just saw there are new |
You are absolutely right, clean up is long overdue. At this point I will likely do this at once with |
Dear httplib2-devs,
it seems like the test-suite of this package (in
python3/httplib2test.py
) is broken, due to the fact that it calls external APIs on servers which do not seem to exist anymore... (athttp://bitworking.org/projects/httplib2/test/
).IMO it would be better to use a mock HTTP server, like https://github.com/gabrielfalcao/HTTPretty, which enables self-sustained testing.
For Debian/Ubuntu, I've worked on a patch to disable/skip most of the broken tests. But I've also started to fix some of those via the
HTTPretty
mock HTTP server. Please have a look at my patch and consider if using HTTPretty would be useful to improve the testability of your application:https://git.launchpad.net/~slyon/ubuntu/+source/python-httplib2/tree/debian/patches/0003-Fix-autopkgtests.patch?h=fix-autopkgtest
The text was updated successfully, but these errors were encountered: