Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark #5

Open
yisibl opened this issue Oct 16, 2021 · 3 comments
Open

Add benchmark #5

yisibl opened this issue Oct 16, 2021 · 3 comments

Comments

@yisibl
Copy link

yisibl commented Oct 16, 2021

Benchmark helps us better understand how to choose between similar libraries.

Thanks!

@pimterry
Copy link
Member

I'm not likely to be able to do this myself any time soon, but I would happily accept PRs adding benchmark data (along with the scripts used) if you or anybody else is interested in that.

@yisibl
Copy link
Author

yisibl commented Oct 18, 2021

I added the benchmark here, but brotli-wasm reported an error.
https://github.com/yisibl/brotli-js/blob/c89ae193a882dbafcf3372f2c42fb65a376845e6/benchmark/bench.ts#L59-L61

@pimterry
Copy link
Member

Can you share the error that you're seeing from brotli-wasm? In your CI logs, it looks like everything passes on all platforms except i686-pc-windows-msvc, and the only error there is:

× test\index.spec.ts exited with a non-zero exit code: 3221225477

I can't see anything about brotli-wasm itself in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants