Static roles will no longer get wiped out after hubot initializes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @patcon @ferrari @alexleigh @lwhitworth $ npm i ceci-woodward/hubot-auth -S |
|
Anyone know when this will get merged? Currently I'm having to checkout from git for each deploy. The current release definitely broken. |
dberzano
pushed a commit
to dberzano/alihubot
that referenced
this pull request
Jul 27, 2016
`hubot-auth` is broken upstream. See hubot-archive/hubot-auth#38
| storedRoles = robot.brain.get('roles') | ||
| unless storedRoles | ||
| robot.brain.set('roles', {}) | ||
| storedRoles = robot.brain.get('roles') |
There was a problem hiding this comment.
Hmm I have just noticed that this part loads data without making sure the brain connection was established. In my case I am using a Redis brain and the connection occurs after robot.brain.get(). The net result is that I lose stored roles.
|
This shouldn't be merged due to it breaking backwards compatability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning roles to a user on startup caused hubot brain to add users with invalid ids/names and add the roles to said user. The only reason the tests didn't fail is due to the id and name being the same in all cases.
note: the reason I didn't add/update any test cases is due to hubot-test-helper not supporting custom ids.
Fixes #36 and fixes #37
Verified in Slack:
