Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings page does not reflect selected Theme #746

Open
hungryalgo opened this issue Jan 28, 2024 · 1 comment · May be fixed by #782
Open

settings page does not reflect selected Theme #746

hungryalgo opened this issue Jan 28, 2024 · 1 comment · May be fixed by #782
Labels
front This issue is related to the front-end of the app. question Further information is requested

Comments

@hungryalgo
Copy link

Settings page is always light/white regardless of the Theme selected (Dark or Light).

Is this intentional or we just did not have time to respect the selected Theme?

If we need to fix this, how much work load do you expect? Just small change on the main settings page (settings/+layout.svelte) or do we need to change every UI piece in settings? I might want to fix this if this is not huge.

thanks
@nsarrazin nsarrazin added question Further information is requested front This issue is related to the front-end of the app. labels Jan 29, 2024
@nsarrazin
Copy link
Collaborator

Yes i think for now that's by design, but I would like to fix it eventually. I think we need to start making components because it's a lot of tailwind classes everywhere atm.

KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 5, 2024
@KartikGS
Fixes huggingface#746: settings page in dark mode
85c44b6
@KartikGS KartikGS linked a pull request Feb 5, 2024 that will close this issue
Open
KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 6, 2024
@KartikGS
Fixes huggingface#746: dark mode - formatting
be637cd
KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 6, 2024
@KartikGS
Merge branch 'main' of https://github.com/huggingface/chat-ui into fr…
41f24b2 
…ont/setting_page_theme

Fixes huggingface#746: Settings dark mode - merge
KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 6, 2024
@KartikGS
Fixes huggingface#746: settings page dark mode - rebase
d00ecbb
KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 6, 2024
@KartikGS
Fixes huggingface#746: dark mode - formatting
851a7a4
KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 6, 2024
@KartikGS
Fixes huggingface#746: settings page dark mode - rebase
d741c2a
KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 6, 2024
@KartikGS
Fixes huggingface#746: dark mode - formatting
9737ef1
KartikGS added a commit to KartikGS/chat-ui that referenced this issue Feb 14, 2024
@KartikGS
Fixes huggingface#746: format and merge
a56a3c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
front This issue is related to the front-end of the app. question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: settings page in dark mode KartikGS/chat-ui
2 participants
@hungryalgo @nsarrazin