Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClojureScript port #22

Open
michalmarczyk opened this issue Sep 23, 2013 · 4 comments
Open

ClojureScript port #22

michalmarczyk opened this issue Sep 23, 2013 · 4 comments

Comments

@michalmarczyk
Copy link

I've got a ClojureScript port of Criterium @ https://github.com/michalmarczyk/criterium/tree/cljs; would you be interested in merging it in?

Not making this a pull request yet, because I'm expecting to do a ton of ClojureScript benchmarking in the coming week or so, which should be a good opportunity to check if I've missed any issues and do any necessary ironing out.

@hugoduncan
Copy link
Owner

Happy to see a ClojureScript port. To merge it would require some effort to put common code into cljx files [1] or crossovers [2].

[1] https://github.com/lynaghk/cljx
[2] https://github.com/emezeske/lein-cljsbuild/blob/master/doc/CROSSOVERS.md

@michalmarczyk
Copy link
Author

Sure, I'm happy to convert to a code sharing arrangement. I'll get around to that during or just after the "stress testing" mentioned above.

@magomimmo
Copy link

Is there any advance regarding this port of Criterium on CLJS?

Many thanks for criterium, and not not only for that ;-)

@loganpowell
Copy link

👍 for a clojurescript option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants