Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #38

Open
kurtstoll opened this issue Jan 12, 2016 · 3 comments
Open

Typo #38

kurtstoll opened this issue Jan 12, 2016 · 3 comments

Comments

@kurtstoll
Copy link

Readme says to call: criterium.core/estimated-overhead! to force recalculation of overhead.

However, the real name of this function is: criterium.core/estimatated-overhead!

Note the extra "ta".

@russellwhitaker
Copy link

@kurtstoll
Copy link
Author

So, I don’t know why the search doesn’t find it (maybe I also misspelled it?).

But, it is in the API documentation:

estimatated-overhead!

And, when I run from the repl:

user=> estimatated-overhead!
#<core$estimatated_overhead_BANG_ criterium.core$estimatated_overhead_BANG_@30207ec5>

user=> estimated-overhead!

CompilerException java.lang.RuntimeException: Unable to resolve symbol: estimated-overhead! in this context, compiling:(/private/var/folders/g5/tggw_zcd63b80vp5dzh7hxf00000gp/T/form-init9216678087862186527.clj:1:4418)

On Jan 11, 2016, at 4:17 PM, Russell Whitaker notifications@github.com wrote:

Have you actually confirmed that with a search?
https://github.com/hugoduncan/criterium/search?utf8=✓&q=estimated-overhead https://github.com/hugoduncan/criterium/search?utf8=%E2%9C%93&q=estimated-overhead : 2 hits
https://github.com/hugoduncan/criterium/search?utf8=✓&q=estimatated-overhead&type=Code https://github.com/hugoduncan/criterium/search?utf8=%E2%9C%93&q=estimatated-overhead&type=Code : 0 hits


Reply to this email directly or view it on GitHub #38 (comment).

@timmc
Copy link

timmc commented Mar 23, 2016

@kurtstoll Looks like it was already fixed in v0.4.4 with 21ad1ea. I think you just had an old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants