New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIGNOR implementation probably has a bug #56

Open

nilern opened this issue Feb 13, 2022 · 0 comments

nilern commented Feb 13, 2022 •

edited

This code has no effect because for is lazy and its result is not being used here. Without digging into the math I can't tell whether it is a bug.

If it indeed is a bug I would suggest replacing the for with

(dotimes [i c]
  (let [j (int i)]
    (aset s-adzigr j (/ (aget s-adzigx (inc j)) (aget s-adzigx j)))))

(Incidentally, the Integer type hint also has no effect so I removed that.)

If this is not a bug the for can just be removed as dead code.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment