Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next exchange to include? #54

Open
ainestal opened this issue Dec 7, 2017 · 15 comments
Open

Next exchange to include? #54

ainestal opened this issue Dec 7, 2017 · 15 comments

Comments

@ainestal
Copy link
Contributor

ainestal commented Dec 7, 2017

With the idea in mind of gathering feedback from our users, I would like to propose to the community to ask for inclusions of new exchanges in the library. Something as simple as:

What exchange/s would you like to include in Coinnect and why ?

What do you think @hugues31 ?

@hugues31
Copy link
Owner

hugues31 commented Dec 7, 2017

Yep that's a great idea :) is there a way to create a poll in github or should we use an external services ?

@ainestal
Copy link
Contributor Author

ainestal commented Dec 8, 2017

I don't think there is a poll system in github, external services have to be used. We can begin just with leaving this Issue here. We can link it in the README.
The "why" is also very interesting and here we have the space to collect them while we would lose it if we use a simple poll.

@not-inept
Copy link

It might also be simple to have a link to this issue and have folks use the 👍 emojii reaction to comments to indicate their votes.

I think it'd be good to see gdax integrated.

@hugues31
Copy link
Owner

hugues31 commented Dec 9, 2017

I added a link in the readme. You can use this discussion to vote for an exchange :)

@inv2004
Copy link

inv2004 commented Dec 13, 2017

bitmex ?

@crackcomm
Copy link

crackcomm commented Dec 13, 2017

China might be something to think about.

EDIT: South Korea - https://www.bithumb.com/

@crackcomm
Copy link

By the way, are you interested in real market functionality or just API?

@ainestal
Copy link
Contributor Author

@not-inept I started implementing Gdax. For now it should be possible to get the ticker and orderbook for all the pairs in the exchange.

@crackcomm what do you mean by real market functionality and just API?

@hugues31
Copy link
Owner

Thanks to @ainestal, Gdax is implemented in Coinnect (only ticker and orderbook). We need to provide a more complete access to the API thought.

@tbourvon
Copy link

I'm pretty interested in contributing to the GDAX API as well. In fact I implemented a PoC with the ticker request yesterday as well, before seeing the comments here. Is there a way we could coordinate our efforts here?

@hugues31
Copy link
Owner

@tbourvon Hello! You could take a look at the code submitted by the GDAX PR (#58) and see what you can improve :) It should be straightforward to implement the remaining endpoints now

@theashguy
Copy link

Cryptopia, Kucoin, BTCMarkets for the Crypto-Rustaceans down under.

The first two because they're great exchanges with a wealth of Alts on there giving some interesting trade ops to play with in code, the third because they're they best available on-ramp for Aussie dollars to Crypto.

I hacked together a working BTC Markets connector over christmas so I might look at spending some time over the next period rewriting this following the same patterns as you're using here and then PR it through?

👍

@hugues31
Copy link
Owner

Hi @theashguy, feel free to send a PR with your implementation. You can copy/paste the implementation from Kraken/Poloniex to serve as a guide. The API will be greatly improved in the next version with Futures support but for now we keep it as is :)

@PP-AR-T
Copy link

PP-AR-T commented Mar 15, 2022

Kucoin would be nice, I am happy to support on that, I will try to see how far I can get on my own :). PD: Nice Project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants