Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on CRA ESLint config #285

Open
kadamwhite opened this issue Jul 15, 2022 · 0 comments
Open

Remove dependency on CRA ESLint config #285

kadamwhite opened this issue Jul 15, 2022 · 0 comments
Labels

Comments

@kadamwhite
Copy link
Contributor

The create-react-app eslint configuration which we extend is the source of many of our peer dependency errors. We need to categorically overhaul and update our peer deps, but for now, I propose we remove the CRA dependency in favor of copying those rules which it provides directly into our first-party HM configuration.

As an experiment I have done this on a plugin which was previously using this configuration, humanmade/datavis-block, and by removing CRA I was able to eliminate a peer dependency warning which prevented the Create Release GitHub action from running properly.

While the result is a more verbose rules list, having fewer entries in the extends array—and, critically, not depending on any third-party ESLint configuration which defines its own peer dependencies which may conflict with ours—will make this project more maintainable, and avoid the need to use --legacy-peer-deps.

@ntwb ntwb added the eslint label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants