Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPCS/I18n refactor breaks HM-Minimum on PHP 8.2 #308

Open
benjaminprojas opened this issue Apr 7, 2023 · 3 comments
Open

WPCS/I18n refactor breaks HM-Minimum on PHP 8.2 #308

benjaminprojas opened this issue Apr 7, 2023 · 3 comments

Comments

@benjaminprojas
Copy link

WPCS recently deprecated a temporary property called check_translator_comments that is currently being used in the HM-Minimum ruleset.

Commit details here: WordPress/WordPress-Coding-Standards@31064cf

Affected code is here:

<rule ref="WordPress.WP.I18n">
<properties>
<property name="check_translator_comments" value="false" />
</properties>

I think the solution is as easy as:

<rule ref="WordPress.WP.I18n">
	<exclude name="WordPress.WP.I18n.MissingTranslatorsComment" />
	...
@rmccue
Copy link
Member

rmccue commented Feb 21, 2024

Thanks! I've fixed this in #314 as part of our phpcs upgrade.

@benjaminprojas
Copy link
Author

@rmccue that's great to hear! We ended up forking this repo and bringing it all up to speed for PHP 8.2 as I didn't think it was being maintained anymore. Excited to see these updates come through 😄

@rmccue
Copy link
Member

rmccue commented Feb 27, 2024

We use it every day on many projects, we've just been slow to update to PHP 8.2 due to WP's compatibility with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants