Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Check rollback unnecessary message #40

Open
padraic opened this issue May 16, 2017 · 0 comments
Open

Check rollback unnecessary message #40

padraic opened this issue May 16, 2017 · 0 comments
Milestone

Comments

@padraic
Copy link
Collaborator

padraic commented May 16, 2017

When rolling back to an older release (but there is none), the result message isn't an error, but it suggests a successful rollback anyway.

Edit: Actually there is a backup - the problem is that we're not deleting backups after failed downloads, so rollbacks always succeed in that event. The impact is harmless but should be avoided by cleaning up after download errors.

@padraic padraic added this to the 1.1.0 milestone May 16, 2017
padraic added a commit that referenced this issue May 17, 2017
Ensure backup phar (made pre-download) is deleted if download fails
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant