Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

a problem in a dependend library causes the github strategy to fail on PHP versions < 5.6.0 #9

Open
ppetermann opened this issue Jun 4, 2015 · 7 comments

Comments

@ppetermann
Copy link

the issue described in:
humbug/file_get_contents#4

causes the github strategy (on PHP < 5.6.0) to fail with:
file_get_contents(): Peer certificate CN=s3.amazonaws.com' did not match expected CN=github.com'

@aik099
Copy link
Contributor

aik099 commented May 29, 2016

Also having same problem. I see this haven't been fixes for almost 1 year now.

@aik099
Copy link
Contributor

aik099 commented May 29, 2016

I'm wondering why curl with same SSL peer verification (CURLOPT_SSL_VERIFYHOST option) can't be used instead of humbug_get_contents function/package.

@aik099
Copy link
Contributor

aik099 commented May 29, 2016

Here is what I've did in my library fork to get this working: console-helpers@6dc6cda

@padraic
Copy link
Collaborator

padraic commented Mar 29, 2017

Still needed?

Sorry for the delay, been AWOL.

@aik099
Copy link
Contributor

aik099 commented Mar 29, 2017

Sure. But this original issue that needs fixing is humbug/file_get_contents#4. This issue is just a link so that we'll know that what's happening in here is result of an issue in a dependency.

@theofidry
Copy link
Member

on a side note, would it make sense to move https://github.com/padraic/file_get_contents under the Humbug umbrella?

@padraic
Copy link
Collaborator

padraic commented Apr 14, 2017

@theofidry Absolutely. I also have the github site for the PHAR downloads.

Edit: Transferred the file_get_contents repo and updated the Packagist site.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants