Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Drawer causing issue with navigation #669

Open
FortyGazelle700 opened this issue Jan 20, 2024 · 3 comments
Open

docs: Drawer causing issue with navigation #669

FortyGazelle700 opened this issue Jan 20, 2024 · 3 comments
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation

Comments

@FortyGazelle700
Copy link

Describe the bug

When scroll down by some amount and open a drawer, fixed items like navigation disappear / fallback to very top of the page, instead of top of paint.

Reproduction

  1. Go to shadcn-svelte's Dialog Page or shadcn-svelte January 2024 Changelog
  2. Scroll down so that you can see the open drawer button, but just scroll down
  3. Click open drawer
  4. HERE; Navigation and other items break

Logs

N/A

System Info

Running Edge 119.0.2151.58 on Manjaro (Arch) Linux

Severity

annoyance
@FortyGazelle700 FortyGazelle700 added the type: bug A confirmed report of unexpected behavior in the application label Jan 20, 2024
@huntabyte huntabyte removed the type: bug A confirmed report of unexpected behavior in the application label Jan 20, 2024
@huntabyte huntabyte changed the title Drawer docs: Drawer causing issue with navigation Jan 20, 2024
@huntabyte huntabyte added the type: documentation A change or addition to the documentation label Jan 20, 2024
@HubbeDev
Copy link
Contributor

@FortyGazelle700 From what I can see the same thing happens in the original shadcn-ui. And it's actually worse there where the header stays at the top of the dom after the drawer is opened. I think you should open the same issue there before it should be addressed here. What do you think @huntabyte?

@FortyGazelle700
Copy link
Author

FortyGazelle700 commented Jan 27, 2024 •
edited

From what I see Bekacru had found it out Dec 22, 2023 and made an Issue / Pull Request found here: fix(www): vaul drawer wrapper is causing the side bar to break its stickiness #2147

@HubbeDev
Copy link
Contributor

@FortyGazelle700 Aha i se. thanks, I did not have the time right now to look for it. Think we should wait until it's merged.

@huntabyte huntabyte added the status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HubbeDev @huntabyte @FortyGazelle700