Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMMatrix implementation is incomplete #120

Open
jiayihu opened this issue Apr 30, 2024 · 4 comments
Open

DOMMatrix implementation is incomplete #120

jiayihu opened this issue Apr 30, 2024 · 4 comments

Comments

@jiayihu
Copy link

jiayihu commented Apr 30, 2024

The DOMMatrix implementation is quite incomplete in this library, such as it's missing .multiply method. I found a modern and quite complete implementation with https://github.com/thednp/dommatrix, what do you think of using that as replacement instead?

@hustcc
Copy link
Owner

hustcc commented Apr 30, 2024

The DOMMatrix implementation is quite incomplete in this library, such as it's missing .multiply method. I found a modern and quite complete implementation with https://github.com/thednp/dommatrix, what do you think of using that as replacement instead?

very good,can help with a pr?

@jiayihu
Copy link
Author

jiayihu commented Apr 30, 2024

Sure, will do 👍

@hustcc
Copy link
Owner

hustcc commented Apr 30, 2024

I want to know whether the repo is ok, it looks star, and the download is not high.

@jiayihu
Copy link
Author

jiayihu commented Apr 30, 2024

It’s not well known I think because it’s a very small niche running DOMMatrix on node. I’ve used for our production app, which is Miro-like, without issues so far.
Anyway as far as the existing tests pass it should be fine. But we can wait and see what other people think. I opened an issue because it took me a bit to find out that this lib was mocking DOMMatrix but with a limited API surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants