-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot Login with ProtonDrive when two password mode is enabled #180
Comments
Hey @MaoMaoCake! Celeste doesn't currently support two password mode, as I was afraid it would cause confusion for users who weren't aware on what it is. If this kind of functionality were to be shown in the UI, I'd probably want it behind some "advance config" toggle, but I haven't been able to think of a good way to do that yet. How big of a blocker is this for you? I'm not super involved in the Proton ecosystem, does having 2FA enabled on your account not work enough over the two password stuff? |
hi, thanks for the response. proton's 2 password mode protects drive mail and calendar but does not protect vpn. I think the rational behind their choice is that you can have vpn access on devices that you don't want access to mail. It's not much of an issue to me right not since I no longer have the need for it. as for implementation maybe hide the toggle behind a gear icon on the login page? |
Cool, thanks for letting me know how that all works @MaoMaoCake! I still don't completely understand why most people would need it, but it definitely doesn't hurt to support it for the people that still want it turned on.
I think that'd be a really good idea, just having the button in the corner sounds like a really clean way of doing things. I'll try to give that a go sometime soon. |
Two password mode is just another layer of security, but one that can be quite important. For example the second password can be withheld from password manager, kept in one's head, so even if it was accessed by a third party (device stolen, data breach, etc.) the Proton account would still be inaccessible to a bad actor. It's something I wouldn't be comfortable disabling, so support for it would be immensely helpful. With regards to implementation, you could duplicate how 2FA uses an optional checkbox during login. |
Also interested in support for two-password mode, it is an essential feature in my opinion. |
Steps to recreate:
The text was updated successfully, but these errors were encountered: