Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type hinting in src/Services/Library/HttpClient.php #1368

Open
morvaim2 opened this issue Apr 17, 2023 · 0 comments
Open

Wrong type hinting in src/Services/Library/HttpClient.php #1368

morvaim2 opened this issue Apr 17, 2023 · 0 comments
Labels
contributions: welcome 🥇 tag: enhancement 💯 tag: v3

Comments

@morvaim2
Copy link

The PHPDoc type hint of the constructor of src/Services/Library/HttpClient.php says that $client is null, but null is optional, so the type hint should be GuzzleHttp\ClientInterface|null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions: welcome 🥇 tag: enhancement 💯 tag: v3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ApacheEx @morvaim2