Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bondage.js crashes when accessing a node that has "-" in its title #50

Open
blurymind opened this issue Aug 14, 2019 · 2 comments
Open

Comments

@blurymind
Copy link
Collaborator

It seems to be triggered by the node title containing "-" in the title

Yarn loses the color syntax when you use "." or "-" in the title, but if that ever becomes available in bondage.js I can update yarn to allow it too :)

@blurymind
Copy link
Collaborator Author

blurymind commented Aug 14, 2019

another alternative action I can take is to sanitise the title input field of nodes in yarn- so users cant enter/paste anything but [A-z0-9]

should the fix be in yarn(sanitise), or bondagejs(handle)?

@blurymind
Copy link
Collaborator Author

blurymind commented Aug 14, 2019

The sanitisation approach would be easier for me to do, because I already wrote a method to validate titles of nodes and mark them red when they already exist in other nodes. I can just add another check to that, but it will have smaller benefits as compared to being able to handle symbols in the title.

My question is do you think it would be a good idea to add that capability to the parser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant