Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mem leak when releasing stream #631

Open
LYF1999 opened this issue Aug 1, 2022 · 3 comments
Open

Mem leak when releasing stream #631

LYF1999 opened this issue Aug 1, 2022 · 3 comments

Comments

@LYF1999
Copy link

LYF1999 commented Aug 1, 2022

// Release the stream if it requires releasing
if stream.is_released() {
stream.remove();
}
}

There may still leave some bytes releated to the stream in

buffer: Buffer<Event>,
when Counts remove a closed Stream.
This may cause mem leak, Should we remove bytes releated to the stream in remove function?

@LYF1999
Copy link
Author

LYF1999 commented Aug 1, 2022

I am gald to submit a PR to fix that, but we can not access Recv in Counts. if we do that, it will be a large change commit.

@Millione
Copy link

Millione commented Aug 9, 2022

@seanmonstar can we have a look?

@seanmonstar
Copy link
Member

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants