feat(transport): Make transport server and channel independent #1630
+142
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
djc
approved these changes
Jun 20, 2024
| @@ -129,7 +129,3 @@ pub use self::server::ServerTlsConfig; | |||
| #[cfg(feature = "tls")] | |||
| #[cfg_attr(docsrs, doc(cfg(feature = "tls")))] | |||
| pub use self::tls::Identity; | |||
|
|
|||
| #[cfg(feature = "channel")] | |||
There was a problem hiding this comment.
I don't understand how your commit message describes this change? It seems to remove this instance and makes another instance private, but this commit doesn't "move" anything in the sense of creating something new.
There was a problem hiding this comment.
The definition of BoxFuture used in the implementation of the channel feature is moved to the channel module.
|
Ah, sorry, I just missed it for some reason. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allows users to use transport server and channel features independently.
Solution
Warning
This proposal includes a breaking change.
Depends on #1574. Adds a new feature
serverto enable server implementation in transport module and makes server feature and channel feature independent.