compression: handle compression flag but no header #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @davidpdrsn 👋 by chance, could you take a look on this patch ? we would like to move away from our patches/forks 🙂 |
LucioFranco
approved these changes
Oct 19, 2021
| }); | ||
|
|
||
| let mut client = test_client::TestClient::with_interceptor(mock_io_channel(client).await, move |mut req: Request<()>| { | ||
| req.metadata_mut().remove("grpc-encoding"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to some yet unknown reason I ended up with the crash described in #755 where the client set the compressed bit but doesn't send the correct header for the server for compression and the server panics as it reaches an
unreachable!statement with:Note: the client issue might be a problem with one of the configured interceptors in my codebase, to be investigated separately.
Solution
The case where a compression flag is set but no compression header is present is checked while transitioning between the header and body phases an internal error is returned in this case.