health, reflection: make rustfmt dependency optional #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate rustfmt feature from build to health and reflection crates, so that rustfmt dependency can be optionally disabled Fixes #775
LucioFranco
approved these changes
Oct 19, 2021
LucioFranco
reviewed
Oct 19, 2021
|
lol sorry for the noise totally botched the merge xD, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rust Docker images for automated builds don't include rustfmt, so building tonic-health or tonic-reflection crates requires adding a rustfmt installation step to build scripts.
Solution
Make rustfmt requirement optional for tonic-health and tonic-reflection.
This feature is kept enabled as default so that existing code won't break.