Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

OutgoingUrl, OkHttpClient and BearerTokenSupplier should be not be required for incoming-only IlpOverHttpLinks #409

Open
nhartner opened this issue Jan 3, 2020 · 0 comments

Comments

@nhartner
Copy link
Contributor

nhartner commented Jan 3, 2020

IlpOverHttpLink constructor requires both outgoingUrl and bearerTokenSupplier parameters. This should only be required if the IlpOverHttpLink needs to send packets. It should not be required for an incoming-only IlpOverHttpLink.

Consider moving OutgoingUrl, OkHttpClient and BearerTokenSupplier into an OutgoingConnectionSupplier class which uses these fields to construct an http connection. IlpOverHttpLink constructor should have an optional OutgoingConnectionSupplier parameter. If IlpOverHttpLink#sendPacket is invoked, only then will OutgoingConnectionSupplier be required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants