Publish test reports in GHA workflow

[udosson]

The test reports of the GHA workflow should be published to debug the tests if they fail.

The following action could be helpful:
https://github.com/marketplace/actions/test-reporter

[hs2361]

@udosson This GitHub Action does look useful. However, it requires a later release of mocha since PR mochajs/mocha#4607 has been included only in v9.1.0 (added support for exporting test results to a JSON file). We are currently using v9.0 in typescript_app and v8.3.2 in chaincode/typescript. So I'll upgrade the package versions in both to v9.1.0 (or to the latest mocha release), and then try using this Action.

I'll also need to add in a separate workflow for test reports as specified here.

[udosson]

Sounds great. Thanks @hs2361.
Is the link under as specified here the correct one or should it be https://github.com/marketplace/actions/test-reporter#recommended-setup-for-public-repositories?

[hs2361]

Yes, I accidentally put the wrong link there. It's the one you sent.

[hs2361]

@brioux @Zzocker, Could you please take a look at this CI run? The error says that the open function requires atleast 1 parameter, and none were supplied. I took a look at the type definitions for the open function, and in the node_modules/ws-wallet/dist/src/index, the open function has the following function signature:

open(sessionId: string, endpoint?: string): Promise<WsOpenResp>;

However, the function signature given in the secure-identities directory is

blockchain-carbon-accounting/secure-identities/ws-wallet/src/wallet.ts

Line 118 in b5c662f

public async open (): Promise<WsOpenResp> {

This CI run on the main repo passed successfully since it took the latter function definition. However, since the package ws-wallet is imported at the top of the file, and not ../../../../secure-identities/ws-wallet/src, it should have taken the function definition in node_modules. It seemed to have passed anyway, whereas my CI run is failing because of taking the function definition in node_modules (which is what is to be expected since we are not importing it from the secure-identities directory).

Could you please take a look and let me know what is to be done?

[brioux]

@hs2361 the problem with ws-wallet in the fabric-registry tests should be fixed. Check PR 327 where I have fixed the web-socket tests. Sorry for the late response

[hs2361]

Thanks for the fix, @brioux! The tests are passing now.