Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit hook for lint checks #324

Open
2 tasks
hs2361 opened this issue Oct 18, 2021 · 4 comments
Open
2 tasks

Add a pre-commit hook for lint checks #324

hs2361 opened this issue Oct 18, 2021 · 4 comments

Comments

@hs2361
Copy link
Contributor

hs2361 commented Oct 18, 2021

Normally, static code analysis is performed first at the developer's local system before it is run on the CI. This will help us enforce code formatting and styles to an even greater degree, since developers will be prompted to fix their linting right before they commit their code.

For the purpose of adding pre-commit hooks to our project, we can use Husky. This is a popular solution that is employed by a lot of projects.

Lint checks have to be added to two folders:

The lint checks can be run using npm run lint.

@kunaljain0212
Copy link

Can I work on this issue @hs2361?

@hs2361
Copy link
Contributor Author

hs2361 commented Oct 18, 2021

Sure, go ahead @kunaljain0212. Assigning this to you.

@narayand16
Copy link

@hs2361 Can I work on this issue ?

@hs2361
Copy link
Contributor Author

hs2361 commented Oct 19, 2021

Hello @narayand16. Thanks for your interest towards working on the issue. However, this issue has already been assigned. Please take a look at the other open issues in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants