Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should "industry" role be given by contract owner? #503

Open
sichen1234 opened this issue Mar 22, 2022 · 9 comments
Open

should "industry" role be given by contract owner? #503

sichen1234 opened this issue Mar 22, 2022 · 9 comments

Comments

@sichen1234
Copy link
Contributor

@brioux I think the "industry" role should be given by the contract owner, like emissions auditor and offsets dealer. Otherwise if anybody could claim to be an "industry" member the system could get chaotic. What do you think?

@sichen1234
Copy link
Contributor Author

Hi @brioux What do you think of this change?

@brioux
Copy link
Member

brioux commented May 13, 2022

@sichen1234 I have updated the role assignment for industry in the recently added CarbonTracker branch.

There are two industry roles: admin assigned industry dealer, and self or peer assigned industry. Both roles have the same function, they can receive and trade emission tokens and emission certificates (C-NFT) composed of carbon tracker NETs issued by auditors, they can not issue tokens. If needed we can allow admin to disable the self/peer registration of the industry role.

FYI in the branch auditors can now issue both retired emission certificates and transferable (audited) carbon tracker tokens to facilitate supply chain emission tracking. I activated this rather than creating a new auditor role specifically for supply chain tracking.

@sichen1234
Copy link
Contributor Author

sichen1234 commented May 20, 2022 via email

@sichen1234
Copy link
Contributor Author

Based on https://wiki.hyperledger.org/display/CASIG/2022-05-23+Peer+Programming+Call,

  1. Having the Industry role allows the user to issue product emissions certificates
  2. The Industry role should be given by the contract owner
  3. The Industry dealer role will be removed.

@brioux
Copy link
Member

brioux commented Jun 8, 2022

  1. TO-DO
  2. is now configured for both the contract owner (admin) and assigned auditor. This allows auditor to register industry that emission certificates are assigned. The industry will submits product certificates assigned to CarbonTracker (emission certificate) before it is approved by the auditor.
  3. Done

@sichen1234
Copy link
Contributor Author

I still see the Industry Dealer role in the UI:
Screen Shot 2022-06-20 at 1 35 44 PM

Should we remove it?

@sichen1234
Copy link
Contributor Author

Hi @brioux Just wanted to check on this again. There is a button for "Register as Industry" under My Roles.

Who should be able to be registered as Industry? Should this be done only by the contract owner?

@brioux
Copy link
Member

brioux commented Sep 5, 2022

@sichen1234
CarbonTrackers will only be assigned to registered Industry roles.
Since they are issued by auditors, this role is authorized to register them
See the registerIndustry contract function.

Is the add role options showing up in other cases?

@sichen1234
Copy link
Contributor Author

sichen1234 commented Sep 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants