Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(custom-checks): remove NodeJS v12 exclusion logic #1961

Closed
petermetz opened this issue Apr 9, 2022 · 0 comments · Fixed by #1967
Closed

ci(custom-checks): remove NodeJS v12 exclusion logic #1961

petermetz opened this issue Apr 9, 2022 · 0 comments · Fixed by #1967
Assignees
Labels
Developer_Experience good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have P4 Priority 4: Low

Comments

@petermetz
Copy link
Member

While coming up with the fix for #1809
I realized that after upgrading ts-node to the latest available version,
the custom-checks script now can run just fine on NodeJS v12 as well.

Based on the above, we can remove the logic both from tools/ci.sh and
tools/custom-checks/run-custom-checks.ts which stops the custom checks
execution if NodeJS v12 is detected.

The other reason to clean up this from the code is because NodeJS v12 is end of
life now and we no longer include it in the CI at all anyway. So this is one
of those tasks that adds value by removing code instead of adding it.

@petermetz petermetz added Developer_Experience good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have P4 Priority 4: Low labels Apr 9, 2022
@Leeyoungone Leeyoungone self-assigned this Apr 12, 2022
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Apr 12, 2022
Fixes hyperledger#1961

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Apr 20, 2022
Fixes hyperledger#1961

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Apr 25, 2022
Fixes hyperledger#1961

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue May 10, 2022
Fixes hyperledger#1961

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
petermetz pushed a commit to Leeyoungone/cactus that referenced this issue May 11, 2022
Fixes hyperledger#1961

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
petermetz pushed a commit that referenced this issue May 11, 2022
Fixes #1961

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
zondervancalvez pushed a commit to zondervancalvez/cactus that referenced this issue May 18, 2022
Fixes hyperledger#1961

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer_Experience good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have P4 Priority 4: Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants