Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper-trace issues #404

Open
catmando opened this issue Apr 7, 2021 · 0 comments
Open

hyper-trace issues #404

catmando opened this issue Apr 7, 2021 · 0 comments

Comments

@catmando
Copy link
Contributor

catmando commented Apr 7, 2021

  1. Need to add exception exclusions to Operations... i.e. add this method:
def hypertrace_class_exclusions 
  [ list of expected internal exceptions ]
end

define at both class and instance level.

  1. Operations checks the arity of the method to decide whether to forward the parameters, but hypertrace accepts *args (arity -1) this confuses operations and ends up passing a value along. Have to have some way to tell hyperoperation what the real arity was.

  2. line 202 needs a guard so that if parameters is not available we leave well enough alone. (make sure return unless specs works when specs is javascript undefined)

    def map_with_specs(method, actual, show_blank_rest)
      specs = method.parameters
      return unless specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant