You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The search panel (currently behind a flag) can be closing by pressing Esc when the panel has focus or via the "X" button on the right. Clicking the "X" on the right results in the panel hiding with a transition. Pressing Esc causes the panel to instantly disappear with no transition.
The expected behavior is that there should be a transition in both cases.
The reason for the difference is that when clicking the "X", the Dialog component internally initiates the transition before notifying its parent via onClose. When pressing Esc however we immediately update state to close the sidebar panel, which prevents Dialog from getting a chance to initiate the transition. A possible solution would be for Dialog to expose a handle with a close method that triggers the close transition in the normal way.
The text was updated successfully, but these errors were encountered:
This issue is a bit more complex than it might seem and has some implications. We need to put a bit more thinking on it to see where it fits in the grand scheme of things, before we can prioritize it.
We'll share more information as soon as we have it.
The search panel (currently behind a flag) can be closing by pressing Esc when the panel has focus or via the "X" button on the right. Clicking the "X" on the right results in the panel hiding with a transition. Pressing Esc causes the panel to instantly disappear with no transition.
The expected behavior is that there should be a transition in both cases.
The reason for the difference is that when clicking the "X", the
Dialog
component internally initiates the transition before notifying its parent viaonClose
. When pressing Esc however we immediately update state to close the sidebar panel, which preventsDialog
from getting a chance to initiate the transition. A possible solution would be forDialog
to expose a handle with aclose
method that triggers the close transition in the normal way.The text was updated successfully, but these errors were encountered: