Schedule help panel auto-dismiss when automatically opened #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Mar 27, 2024
| session.dismissSidebarTutorial(); | ||
| }, 5 /** 60*/ * 1000); | ||
| } | ||
| }, [currentUserHasAnnotations, isSidebar, profile, session, settings, store]); |
There was a problem hiding this comment.
I'm thinking maybe this logic should be moved to the HelpPanel itself.
In there we are also handling that the show_sidebar_tutorial profile preference is disabled if the panel is manually closed.
When that happens, we should also clear the timeout if it is still in progress.
|
Closing until we have a bit more capacity to review this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive approach to fix #6277
This PR adds a 5-minute timeout that closes the help panel automatically, and is scheduled as soon as some annotation of any type is created by current user, but only if the help panel was auto-displayed in the first place.
When the timeout callback triggers, it not only closes the help panel, but also updates the
show_sidebar_tutorialprofile preference, preventing it to show the next time.There's an edge case, not covered by this PR, which is that, if the timeout is scheduled and the page is reloaded after the callback is executed, the timeout will be re-scheduled from scratch. This is probably negligible, but we could consider tracking the "progress" somehow so that we can continue from there once reloaded.
This PR does not cover animation enhancements described in #6277