Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On PRs the info is either wrongly shown to a comment, or is not shown at all #43

Open
darkred opened this issue Feb 27, 2022 · 1 comment · May be fixed by #44
Open

On PRs the info is either wrongly shown to a comment, or is not shown at all #43

darkred opened this issue Feb 27, 2022 · 1 comment · May be fixed by #44

Comments

@darkred
Copy link

darkred commented Feb 27, 2022 •
edited

The issue is that on PRs the info is either shown to a comment instead of OP, or is not shown at all. It started recently.

It occurs with latest v21.2.21.1941 (with token) with Chrome 98 on win11 using a fresh profile. But it works ok with v21.3.1 with Firefox. There's no error in console except for the last example.

Screenshot examples:

example 1a (to a comment, instead of OP) :

tanmayrajani/notifications-preview-github#114
2022-02-27_211812

example 1b (to a comment, instead of OP) :

tanmayrajani/notifications-preview-github#108
2022-02-27_211704

example 2 (not shown at all) :

tanmayrajani/notifications-preview-github#122
2022-02-27_213559

Error in console for the last example:
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'insertAdjacentHTML')
2022-02-27_213201
@darkred darkred changed the title On PRs the info is either shown to a comment instead of the OP, or is not shown at all On PRs the info is either wrongly shown to a comment, or is not shown at all Feb 28, 2022
@elliotwaite
Copy link

I'm experiencing this issue as well.

@inkydragon inkydragon linked a pull request Aug 9, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update first comment selector one-pr/contributors-on-github
2 participants
@darkred @elliotwaite