Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go version to 1.17, replace golint with staticcheck #222

Merged
merged 7 commits into from May 6, 2022

Conversation

bastianccm
Copy link
Contributor

@bastianccm bastianccm commented Mar 3, 2022

This is for testing coverage reports

  • This requires go 1.17 for running modules

@carstendietrich
Copy link
Member

@bastianccm looks like a nice addition, feel free to bump go version to 1.17 and enable the optional static check checks. And of course please fix the newly raised issues 🙃

@carstendietrich carstendietrich removed their request for review May 6, 2022 09:17
@carstendietrich
Copy link
Member

Updated go version to 1.17, and fixed the staticcheck-raised issues.
The switch of the LogKey constants from type string to type LogKey is a breaking change.

@i-love-flamingo i-love-flamingo deleted a comment from github-actions bot May 6, 2022
@carstendietrich
Copy link
Member

Moved coverage report to separate job, otherwise, we have two comments, one per go version (1.17/1.18)

@carstendietrich carstendietrich changed the title test(coverage): include coverage report chore(go): bump go version to 1.17 May 6, 2022
@carstendietrich carstendietrich changed the title chore(go): bump go version to 1.17 chore: bump go version to 1.17, add staticcheck May 6, 2022
@carstendietrich carstendietrich changed the title chore: bump go version to 1.17, add staticcheck chore: bump go version to 1.17, replace golint with staticcheck May 6, 2022
@bastianccm
Copy link
Contributor Author

LGTM, but i can't approve my own PR

Copy link
Member

@tessig tessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Code Coverage

Package Line Rate Health
flamingo.me/flamingo/v3/core/auth 10%
flamingo.me/flamingo/v3/core/auth/fake 50%
flamingo.me/flamingo/v3/core/auth/http 40%
flamingo.me/flamingo/v3/core/auth/oauth 46%
flamingo.me/flamingo/v3/core/cache 52%
flamingo.me/flamingo/v3/core/gotemplate 87%
flamingo.me/flamingo/v3/core/healthcheck/interfaces/controllers 76%
flamingo.me/flamingo/v3/core/healthcheck 64%
flamingo.me/flamingo/v3/core/internalauth 100%
flamingo.me/flamingo/v3/core/locale/application 87%
flamingo.me/flamingo/v3/core/locale/domain 75%
flamingo.me/flamingo/v3/core/locale/interfaces/controllers 100%
flamingo.me/flamingo/v3/core/locale/interfaces/templatefunctions 92%
flamingo.me/flamingo/v3/core/locale 59%
flamingo.me/flamingo/v3/core/oauth/application 4%
flamingo.me/flamingo/v3/core/oauth/domain 62%
flamingo.me/flamingo/v3/core/oauth 55%
flamingo.me/flamingo/v3/core/requestlogger 3%
flamingo.me/flamingo/v3/core/requesttask 10%
flamingo.me/flamingo/v3/core/robotstxt 50%
flamingo.me/flamingo/v3/core/runtime 77%
flamingo.me/flamingo/v3/core/security/application/role 95%
flamingo.me/flamingo/v3/core/security/application 98%
flamingo.me/flamingo/v3/core/security/application/voter 100%
flamingo.me/flamingo/v3/core/security/interface/controller 100%
flamingo.me/flamingo/v3/core/security/interface/middleware 72%
flamingo.me/flamingo/v3/core/security 59%
flamingo.me/flamingo/v3/core/zap 43%
flamingo.me/flamingo/v3/framework/cmd 12%
flamingo.me/flamingo/v3/framework/config 45%
flamingo.me/flamingo/v3/framework/flamingo 8%
flamingo.me/flamingo/v3/framework 28%
flamingo.me/flamingo/v3/framework/opencensus 30%
flamingo.me/flamingo/v3/framework/prefixrouter 43%
flamingo.me/flamingo/v3/framework/systemendpoint 27%
flamingo.me/flamingo/v3/framework/testutil 0%
flamingo.me/flamingo/v3/framework/web 49%
Summary 45% (2895 / 6495)

@carstendietrich carstendietrich merged commit ae2b39e into master May 6, 2022
@carstendietrich carstendietrich deleted the coverage-report branch May 6, 2022 12:35
@github-actions github-actions bot mentioned this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants