Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runAfter works only for installations with UI (at least for msi) #63

Open
coderartem opened this issue Sep 13, 2018 · 3 comments
Open

Comments

@coderartem
Copy link

runAfter works only for installations with UI because that action is hooked to finish button

Can we have it work for silent installations also?

@gamma
Copy link
Member

gamma commented Sep 14, 2018

Which platform are you referring to or do you mean in general?

@coderartem
Copy link
Author

I generated msi and found this inconvenience. Not sure if it's a problem for other types of installer

@coderartem
Copy link
Author

coderartem commented Sep 16, 2018

UI
Publish Control="Finish" Dialog="ExitDialog" Event="DoAction" Value="runAfter">NOT Installed
OR REINSTALL OR UPGRADINGPRODUCTCODE< /Publish
/UI

That's how runAfter is being invoked currently, it's just listen for finish button to be pressed. So if there is no UI and dialogs it's never going to be executed. I think you can trigger it from InstallExecuteSequence instead. Something like this:

InstallExecuteSequence
Custom Action='runAfter' After ='InstallFinalize'>NOT Installed OR REINSTALL OR
UPGRADINGPRODUCTCODE</Custom
/InstallExecuteSequence

@coderartem coderartem changed the title runAfter works only for installations with UI runAfter works only for installations with UI (at least for msi) Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants