Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addDetector type does not match implementation #282

Closed
ab-pm opened this issue Mar 30, 2024 · 1 comment
Closed

addDetector type does not match implementation #282

ab-pm opened this issue Mar 30, 2024 · 1 comment

Comments

@ab-pm
Copy link

ab-pm commented Mar 30, 2024

I tried to use chaining on addDetector but it didn't work.

The method is declared as

/**
* Adds detector.
*/
addDetector(detector: CustomDetector): I18nextBrowserLanguageDetector;
but implemented as
addDetector(detector) {
this.detectors[detector.name] = detector;
}

Either it should be declared to return void or implemented to return this;.

@adrai
Copy link
Member

adrai commented Mar 30, 2024

addressed with v7.2.1

@adrai adrai closed this as completed Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants