CHANGELOG.md

@@ -1,3 +1,7 @@
+### 14.0.3
+
+- revert changes done in v14.0.2 since it breaks normal language change render updates
+
 ### 14.0.2
 
 - Fix/bug [1691](https://github.com/i18next/react-i18next/issues/1691) make returned t function identical upon second effect run in strict mode [1716](https://github.com/i18next/react-i18next/pull/1716)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-i18next",
-  "version": "14.0.2",
+  "version": "14.0.3",
   "description": "Internationalization for react done right. Using the i18next i18n ecosystem.",
   "main": "dist/commonjs/index.js",
   "types": "./index.d.mts",

react-i18next.js

@@ -612,12 +612,6 @@
 	  }, [value, ignore]);
 	  return ref.current;
 	};
-	function alwaysNewT(i18n, language, namespace, keyPrefix) {
-	  return i18n.getFixedT(language, namespace, keyPrefix);
-	}
-	function useMemoizedT(i18n, language, namespace, keyPrefix) {
-	  return react.useCallback(alwaysNewT(i18n, language, namespace, keyPrefix), [i18n, language, namespace, keyPrefix]);
-	}
 	function useTranslation(ns) {
 	  let props = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
 	  const {
@@ -656,8 +650,9 @@
 	  namespaces = typeof namespaces === 'string' ? [namespaces] : namespaces || ['translation'];
 	  if (i18n.reportNamespaces.addUsedNamespaces) i18n.reportNamespaces.addUsedNamespaces(namespaces);
 	  const ready = (i18n.isInitialized || i18n.initializedStoreOnce) && namespaces.every(n => hasLoadedNamespace(n, i18n, i18nOptions));
-	  const memoGetT = useMemoizedT(i18n, props.lng || null, i18nOptions.nsMode === 'fallback' ? namespaces : namespaces[0], keyPrefix);
-	  const getT = () => memoGetT;
+	  function getT() {
+	    return i18n.getFixedT(props.lng || null, i18nOptions.nsMode === 'fallback' ? namespaces : namespaces[0], keyPrefix);
+	  }
 	  const [t, setT] = react.useState(getT);
 	  let joinedNS = namespaces.join();
 	  if (props.lng) joinedNS = `${props.lng}${joinedNS}`;
@@ -676,9 +671,7 @@
 	        });
 	      } else {
 	        loadNamespaces(i18n, namespaces, () => {
-	          if (isMounted.current) {
-	            setT(() => alwaysNewT(i18n, props.lng || null, i18nOptions.nsMode === 'fallback' ? namespaces : namespaces[0], keyPrefix));
-	          }
+	          if (isMounted.current) setT(getT);
 	        });
 	      }
 	    }

src/useTranslation.js

@@ -1,4 +1,4 @@
-import { useState, useEffect, useContext, useRef, useCallback } from 'react';
+import { useState, useEffect, useContext, useRef } from 'react';
 import { getI18n, getDefaults, ReportNamespaces, I18nContext } from './context.js';
 import { warnOnce, loadNamespaces, loadLanguages, hasLoadedNamespace } from './utils.js';
 
@@ -10,19 +10,6 @@ const usePrevious = (value, ignore) => {
   return ref.current;
 };
 
-function alwaysNewT(i18n, language, namespace, keyPrefix) {
-  return i18n.getFixedT(language, namespace, keyPrefix);
-}
-
-function useMemoizedT(i18n, language, namespace, keyPrefix) {
-  return useCallback(alwaysNewT(i18n, language, namespace, keyPrefix), [
-    i18n,
-    language,
-    namespace,
-    keyPrefix,
-  ]);
-}
-
 export function useTranslation(ns, props = {}) {
   // assert we have the needed i18nInstance
   const { i18n: i18nFromProps } = props;
@@ -68,16 +55,14 @@ export function useTranslation(ns, props = {}) {
     (i18n.isInitialized || i18n.initializedStoreOnce) &&
     namespaces.every((n) => hasLoadedNamespace(n, i18n, i18nOptions));
 
-  // binding t function to namespace (acts also as rerender trigger *when* args have changed)
-  const memoGetT = useMemoizedT(
-    i18n,
-    props.lng || null,
-    i18nOptions.nsMode === 'fallback' ? namespaces : namespaces[0],
-    keyPrefix,
-  );
-  // using useState with a function expects an initializer, not the function itself:
-  const getT = () => memoGetT;
-
+  // binding t function to namespace (acts also as rerender trigger)
+  function getT() {
+    return i18n.getFixedT(
+      props.lng || null,
+      i18nOptions.nsMode === 'fallback' ? namespaces : namespaces[0],
+      keyPrefix,
+    );
+  }
   const [t, setT] = useState(getT);
 
   let joinedNS = namespaces.join();
@@ -98,17 +83,7 @@ export function useTranslation(ns, props = {}) {
         });
       } else {
         loadNamespaces(i18n, namespaces, () => {
-          if (isMounted.current) {
-            // despite that no memoization arguments changed, supply always new T to trigger rerender
-            setT(() =>
-              alwaysNewT(
-                i18n,
-                props.lng || null,
-                i18nOptions.nsMode === 'fallback' ? namespaces : namespaces[0],
-                keyPrefix,
-              ),
-            );
-          }
+          if (isMounted.current) setT(getT);
         });
       }
     }