Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to abandon “input object” approach #135

Open
zhusee2 opened this issue Jan 30, 2018 · 0 comments
Open

Refactor to abandon “input object” approach #135

zhusee2 opened this issue Jan 30, 2018 · 0 comments

Comments

@zhusee2
Copy link
Contributor

zhusee2 commented Jan 30, 2018

There are 3 components left using a previous “input object”, which explicitly expects an input prop to pass all input-related props to their inner <input>. They are:

  • <Checkbox>
  • <SearchInput>
  • <Switch>

As their main purpose is to act as real inputs with custom appearance, they should take all unknown props as input props by default.

@zhusee2 zhusee2 changed the title Refactor <Switch> to pass unknown props to input Refactor to abandon 'input object' approach Jan 30, 2018
@zhusee2 zhusee2 changed the title Refactor to abandon 'input object' approach Refactor to abandon “input object” approach Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant