Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct .npmrc env variable warnings #1758

Closed
wants to merge 1 commit into from

Conversation

federicobadini
Copy link
Contributor

@federicobadini federicobadini commented Jun 14, 2023

closes #1757

this also fixes NEXT_PUBLIC_STRAPI_ORIGIN in .env.test: it should point to the local Strapi instance

qa_req 0

@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ❌ Failed (Inspect) Jul 4, 2023 10:27am
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 10:27am

@federicobadini federicobadini changed the title feat: correct npmrc env variable warnings Correct .npmrc env variable warnings Jun 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@sterlinghirsh
Copy link
Member

This claims to fix #1757 regarding the FONT_AWESOME token, but I don't see anything about that.

@erinemay
Copy link
Contributor

@federicobadini, it's been a while since this pull saw any action. Poking to check if this is still on your radar.

@federicobadini
Copy link
Contributor Author

Yes, I'm aware of it.
It seemed such a straightforward fix on localhost but Vercel seems not capable to pick env vars if written in a way that does not produces warnings in localhost.

It's really low priority though so I will investigate on this as soon as I've some time available

@dhmacs dhmacs deleted the fix-npmrc-env-variable-warnings branch September 6, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove env variable warnings during dependency install
3 participants