Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberBox's Background Color not working properly in Dark Mode #50

Open
abhay991 opened this issue Mar 30, 2024 · 2 comments
Open

NumberBox's Background Color not working properly in Dark Mode #50

abhay991 opened this issue Mar 30, 2024 · 2 comments
Labels
bug Something isn't working question Further information is requested

Comments

@abhay991
Copy link

abhay991 commented Mar 30, 2024

Describe the bug
NumberBox is not being displayed properly in dark theme mode.

To Reproduce
Steps to reproduce the behavior:

  1. Create any wpf project
  2. Make sure you set dark theme at the time of launch (this is important) cause when you switch to a dark theme in runtime, it works fine.
  3. You will see only the NumberBox component is not taking dark mode effect correctly.

Expected behavior
I expect to see NumberBox's textbox have proper background color.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version 120

Notes: I have faced same issue with ModernWpf for quite long time now.

@NotYoojun
Copy link
Member

Hi, I can't reproduce this bug.
Does this happen in the Gallery app?
What version of this library are you using?

image

If possible, could you please send me your project so I can take a deeper look?

@NotYoojun NotYoojun added bug Something isn't working question Further information is requested labels Apr 4, 2024
NotYoojun added a commit that referenced this issue Jun 5, 2024
@NotYoojun
Copy link
Member

Hi there,

Please check the latest commit: Attempts of #50 · iNKORE-NET/UI.WPF.Modern@2ff4ee2 (github.com)
And see if this problem still exists.

I tried removing the theme-specific resources from NumberBox.xaml, and it works on my computer.
I’m sure this is not the best solution, since this issue is because of the incorrect code of ThemeDictionary and ResourceDictionary.
However, I have no idea to fix this in the best way, and I’m wondering if you guys could help me.

Best regards,
Yoojun Zhou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants