iOS GetResourcePathFromBundle should get path from extension subfolder

[Youlean]

iPlug2/IPlug/IPlugPaths.mm

Line 162 in 6a288dc

pBasePath = [[[[pBundle bundlePath] stringByDeletingLastPathComponent] stringByDeletingLastPathComponent] stringByAppendingString:@"/Resources/"];

isAppExtension could be disabled as if you load iOS plugin on macOS it will crash the host as it can't load the resources.
Or this should be changed somehow:

iPlug2/IGraphics/Platforms/IGraphicsCoreText.mm

Line 48 in 6a288dc

CFLocal<CGDataProviderRef> provider(url.Get() ? CGDataProviderCreateWithURL(url.Get()) : nullptr); // CGDataProviderCreateWithURL will fail in macOS sandbox!

[olilarkin]

PRs welcome.

This stuff is a PITA. Are you trying to compile your iOS app with Catalyst?

[Youlean]

I have fixed some stuff and made it work for my iOS loudness meter lite.

It took me a couple of days to figure what is going on.

This might also help you:

 /*
 ==============================================================================
 
 This file is part of the iPlug 2 library. Copyright (C) the iPlug 2 developers. 
 
 See LICENSE.txt for  more info.
 
 ==============================================================================
*/

#import <CoreAudioKit/AUViewController.h>
#import "IPlugAUAudioUnit.h"
#import "IPlugAUViewController.h"
#include "IPlugPlatform.h"
#include "IPlugLogger.h"

#ifdef OS_IOS
#import "GenericUI.h"
#endif

#if !__has_feature(objc_arc)
#error This file must be compiled with Arc. Use -fobjc-arc flag
#endif

@interface IPlugAUViewController (AUAudioUnitFactory)
@end

#ifdef OS_IOS
#pragma mark - iOS
@implementation IPlugAUViewController

- (AUAudioUnit*) createAudioUnitWithComponentDescription:(AudioComponentDescription) desc error:(NSError **)error
{
  self.audioUnit = [[IPlugAUAudioUnit alloc] initWithComponentDescription:desc error:error];

  dispatch_async(dispatch_get_main_queue(), ^{
    
  // Open window if it is not alredy opened  
  if (![self.audioUnit isWindowOpen])
  {
    [self.audioUnit openWindow:self.view];
  }
    
  });
  
  [self audioUnitInitialized];
  
  return self.audioUnit;
}

#if PLUG_HAS_UI
- (void)viewWillLayoutSubviews
{
  if (self.audioUnit)
  {
    CGRect drawableRect;
    drawableRect = self.view.bounds;
    
    [_audioUnit resize:drawableRect];
  }
  
  [super viewWillLayoutSubviews];
}

-(void) viewWillTransitionToSize:(CGSize)size withTransitionCoordinator:(id<UIViewControllerTransitionCoordinator>)coordinator
{
  [super viewWillTransitionToSize: size withTransitionCoordinator: coordinator];
  
  if (self.audioUnit)
  {
    [coordinator animateAlongsideTransition: nil completion: ^void (id<UIViewControllerTransitionCoordinatorContext>)
     {
      [self.audioUnit layoutUI];
    }];
  }
}

- (void) viewDidLoad
{
  [super viewDidLoad];
}

- (void) viewWillAppear:(BOOL) animated
{
  [super viewWillAppear:animated];
  
  if (self.audioUnit)
  {
    [self.audioUnit openWindow:self.view];
  }
}

- (void)viewDidAppear:(BOOL)animated
{
  [super viewDidAppear:animated];
}

- (void)viewWillDisappear:(BOOL)animated
{
  [super viewWillDisappear:animated];
}

- (void) viewDidDisappear:(BOOL) animated
{
  [super viewDidDisappear:animated];
  
  if (self.audioUnit)
  {
    [self.audioUnit closeWindow];
  }
}

#endif

- (AUAudioUnit*) getAudioUnit
{
  return self.audioUnit;
}

- (void) audioUnitInitialized
{
  dispatch_async(dispatch_get_main_queue(), ^{
    if (self.audioUnit)
    {
      int width = (int) [self.audioUnit width];
      int height = (int) [self.audioUnit height];
      self.preferredContentSize = CGSizeMake(width, height);
      self.view.backgroundColor = UIColor.blackColor;
      
      [self.audioUnit SetIsHostApp: NO];
    }
  });
}

@end

#else // macOS
#pragma mark - macOS
@implementation IPlugAUViewController

- (id) init
{
  self = [super initWithNibName:@"IPlugAUViewController"
                         bundle:[NSBundle bundleForClass:NSClassFromString(@"IPlugAUViewController")]];

  return self;
}

- (AUAudioUnit*) createAudioUnitWithComponentDescription:(AudioComponentDescription) desc error:(NSError **)error
{
  self.audioUnit = [[IPlugAUAudioUnit alloc] initWithComponentDescription:desc error:error];

  return self.audioUnit;
}

- (AUAudioUnit*) getAudioUnit
{
  return self.audioUnit;
}

- (void) audioUnitInitialized
{
  dispatch_async(dispatch_get_main_queue(), ^{
    int viewWidth = (int) [self.audioUnit width];
    int viewHeight = (int) [self.audioUnit height];
    self.preferredContentSize = CGSizeMake (viewWidth, viewHeight);
  });
}

- (void) setAudioUnit:(IPlugAUAudioUnit*) audioUnit
{
  _audioUnit = audioUnit;
  [self audioUnitInitialized];
}

- (void) viewWillAppear
{
  [_audioUnit openWindow:self.view];
}
@end

#endif

[olilarkin]

Thanks for the code but it's not clear how it relates to the issue?

[Youlean]

sorry, it doesn't, but it is needed if you want to load iOS plugin on macOS

[AlexHarker]

GetResourcePathFromBundle() works on IOS, so can you clarify how it breaks when running the IOS plugin on macOS. I can see that we'd want to support it, but we'd want to make sure it works correctly on IOS and macOS - a PR that solves that issue would be very welcome.

Likewise - if you could make a separate issue for the loading stuff and at least a clear issue (and ideally a PR) that would be great.