Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skia METAL bitmap colours appear incorrect #1079

Open
AlexHarker opened this issue Mar 23, 2024 · 4 comments
Open

Skia METAL bitmap colours appear incorrect #1079

AlexHarker opened this issue Mar 23, 2024 · 4 comments
Labels
igraphics Issue relates to igraphics macOS Issue relates to macOS SKIA

Comments

@AlexHarker
Copy link
Collaborator

AlexHarker commented Mar 23, 2024

Describe the bug
All bitmap drawing for me with Skia/METAL on Mac OS Ventura - 2.9 GHz Quad-Core Intel Core i7 - appears to be mapping the pixels or colours incorrectly. Black is appearing as transparent, and white a yellow, suggesting that the expected representation order of colour components is different somewhere in the system to expected. The mapping is consistent, but single channel colours do not appear to be simply transposed.

To Reproduce
Compile IGraphicsTest with Skia and METAL on Mac - view image/SVG/layer controls

Expected behaviour
Colours should draw correctly.

Screenshots
Screenshot 2024-03-23 at 08 58 45
Screenshot 2024-03-23 at 08 58 50
Screenshot 2024-03-23 at 08 58 52
Screenshot 2024-03-23 at 09 19 06

This final example shows a layer onto which four coloured circles with simple colours are drawn (r/g/b are full alpha and full on the channel noted only when drawn).

IMPORTANT DETAILS

  • What plug-in format does it relate to - ALL
  • What platform does it relate to - macOS
  • What IGRAPHICS_BACKEND does it relate to, IGRAPHICS_SKIA with METAL
@AlexHarker AlexHarker added igraphics Issue relates to igraphics macOS Issue relates to macOS SKIA labels Mar 23, 2024
@olilarkin
Copy link
Member

Woah, not seen that before. We are now quite behind with our skia version but also could be a macOS change causing it.

@AlexHarker
Copy link
Collaborator Author

Be good to know if it is something specific to my computer or not.

@olilarkin
Copy link
Member

I will have a go tomorrow

@olilarkin
Copy link
Member

I tried on intel mac with Sonoma with an AMD Radeon Pro 5500 XT 8 GB and the colours are ok here. Pretty sure I also tried it with metal when i had ventura installed on this machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
igraphics Issue relates to igraphics macOS Issue relates to macOS SKIA
Projects
None yet
Development

No branches or pull requests

2 participants