TorusPipe.createAlongArc returns pipe with wrong angular sweep

[dovydasjaru]

Describe the bug
TorusPipe creates a solid that is offset from the curve.

To Reproduce
code snippet:
TorusPipe.createAlongArc(curve, diameter / 2, true)

diameter = 0.009525
curve as json => {"center":[-0.0035718750000000004,0,0],"sweep":[0,90.0050353193204],"vector0":[-0.001190625,0.127,0],"vector90":[0.001190625,7.776507174585693e-18,0.127]}

Expected behavior
TorusPipe creates a solid that is along the curve.

Screenshots

In the screenshot there are four curves making a full circle. But it is visible that part of TorusPipe is outside the curve.

Desktop:

• OS: Windows 11
• Node version v18.17.1
• iTwin.js Version 4.4.9

[dassaf4]

Ultimately the code is failing because the Arc3d is not circular, and TorusPipe assumes circularity. (The arc's vector0 and vector90 are not perpendicular; they are 90.0050353193204 degrees apart.) If you want to avoid the issue now, ensure your input arc is circular, perhaps by using a different constructor that guarantees a circular Arc3d. The fix will enforce circularity of the input arc, so YMMV.