feat: Add locale (zh-tw) meridiem and update format #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin82222
changed the title
iamkun
reviewed
Dec 3, 2022
src/locale/zh-tw.js
Outdated
| @@ -21,8 +21,8 @@ const locale = { | |||
| LTS: 'HH:mm:ss', | |||
| L: 'YYYY/MM/DD', | |||
| LL: 'YYYY年M月D日', | |||
| LLL: 'YYYY年M月D日 HH:mm', | |||
| LLLL: 'YYYY年M月D日dddd HH:mm', | |||
| LLL: 'YYYY年M月D日Ah點mm分', | |||
There was a problem hiding this comment.
can you please revert these two lines to make the same with https://github.com/moment/moment/blob/develop/src/locale/zh-tw.js
Codecov Report
@@ Coverage Diff @@
## dev #2149 +/- ##
===========================================
- Coverage 100.00% 99.81% -0.19%
===========================================
Files 183 183
Lines 2096 2109 +13
Branches 550 554 +4
===========================================
+ Hits 2096 2105 +9
- Misses 0 4 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
LGTM, can you please add some tests to make the CI pass? |
|
test added. |
iamkun
pushed a commit
that referenced
this pull request
Dec 6, 2022
|
🎉 This PR is included in version 1.11.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
epszaw
pushed a commit
to epszaw/dayjs
that referenced
this pull request
Feb 18, 2023
## [1.11.7](iamkun/dayjs@v1.11.6...v1.11.7) (2022-12-06) ### Bug Fixes * Add locale (zh-tw) meridiem ([iamkun#2149](iamkun#2149)) ([1e9ba76](iamkun@1e9ba76)) * update fa locale ([iamkun#2151](iamkun#2151)) ([1c26732](iamkun@1c26732))
jnorris-cs
pushed a commit
to catalystio/dayjs
that referenced
this pull request
Mar 29, 2023
## [1.11.7](iamkun/dayjs@v1.11.6...v1.11.7) (2022-12-06) ### Bug Fixes * Add locale (zh-tw) meridiem ([iamkun#2149](iamkun#2149)) ([1e9ba76](iamkun@1e9ba76)) * update fa locale ([iamkun#2151](iamkun#2151)) ([1c26732](iamkun@1c26732))
ohsory1324
pushed a commit
to ohsory1324/dayjs
that referenced
this pull request
Dec 20, 2023
ohsory1324
pushed a commit
to ohsory1324/dayjs
that referenced
this pull request
Dec 20, 2023
## [1.11.7](iamkun/dayjs@v1.11.6...v1.11.7) (2022-12-06) ### Bug Fixes * Add locale (zh-tw) meridiem ([iamkun#2149](iamkun#2149)) ([1e9ba76](iamkun@1e9ba76)) * update fa locale ([iamkun#2151](iamkun#2151)) ([1c26732](iamkun@1c26732))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#171 Make zh-tw locale can display meridiem format