Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify types of diff #617

Merged
merged 1 commit into from
Jun 18, 2019
Merged

modify types of diff #617

merged 1 commit into from
Jun 18, 2019

Conversation

pochi-sato
Copy link
Contributor

If passing only one argument to a dayjs diff method, it is said that the type is not correct.
So I fixed it.

  • document
    image

  • code
    image

@codecov-io
Copy link

codecov-io commented Jun 18, 2019

Codecov Report

Merging #617 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #617   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines       986    986           
  Branches    141    141           
===================================
  Hits        986    986

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a257c...2e750f5. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Jun 18, 2019

THX

@iamkun iamkun merged commit f0f43d2 into iamkun:dev Jun 18, 2019
iamkun pushed a commit that referenced this pull request Jul 8, 2019
## [1.8.15](v1.8.14...v1.8.15) (2019-07-08)

### Bug Fixes

* Fix dayjs.locale() returns current global locale ([#602](#602)) ([790cd1a](790cd1a))
* Fix incorrect Thai locale translation of July ([#607](#607)) ([43cbfd3](43cbfd3))
* Lowercase french locale months and weekdays ([#615](#615)) ([e5a257c](e5a257c))
* Type - Export Ls object to query all available locales ([#623](#623)) ([f6bfae0](f6bfae0))
* Update  nb (Norsk Bokmål) locale ([#604](#604)) ([907f5c9](907f5c9))
* Update types of `.diff` API ([#617](#617)) ([f0f43d2](f0f43d2))
@iamkun
Copy link
Owner

iamkun commented Jul 8, 2019

🎉 This PR is included in version 1.8.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 8, 2019
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.15](iamkun/dayjs@v1.8.14...v1.8.15) (2019-07-08)

### Bug Fixes

* Fix dayjs.locale() returns current global locale ([#602](iamkun/dayjs#602)) ([790cd1a](iamkun/dayjs@790cd1a))
* Fix incorrect Thai locale translation of July ([#607](iamkun/dayjs#607)) ([43cbfd3](iamkun/dayjs@43cbfd3))
* Lowercase french locale months and weekdays ([#615](iamkun/dayjs#615)) ([e5a257c](iamkun/dayjs@e5a257c))
* Type - Export Ls object to query all available locales ([#623](iamkun/dayjs#623)) ([f6bfae0](iamkun/dayjs@f6bfae0))
* Update  nb (Norsk Bokmål) locale ([#604](iamkun/dayjs#604)) ([907f5c9](iamkun/dayjs@907f5c9))
* Update types of `.diff` API ([#617](iamkun/dayjs#617)) ([f0f43d2](iamkun/dayjs@f0f43d2))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.15](iamkun/dayjs@v1.8.14...v1.8.15) (2019-07-08)

### Bug Fixes

* Fix dayjs.locale() returns current global locale ([#602](iamkun/dayjs#602)) ([790cd1a](iamkun/dayjs@790cd1a))
* Fix incorrect Thai locale translation of July ([#607](iamkun/dayjs#607)) ([43cbfd3](iamkun/dayjs@43cbfd3))
* Lowercase french locale months and weekdays ([#615](iamkun/dayjs#615)) ([e5a257c](iamkun/dayjs@e5a257c))
* Type - Export Ls object to query all available locales ([#623](iamkun/dayjs#623)) ([f6bfae0](iamkun/dayjs@f6bfae0))
* Update  nb (Norsk Bokmål) locale ([#604](iamkun/dayjs#604)) ([907f5c9](iamkun/dayjs@907f5c9))
* Update types of `.diff` API ([#617](iamkun/dayjs#617)) ([f0f43d2](iamkun/dayjs@f0f43d2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants