-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New @typescript-eslint v4 rules: no-shadow, no-redeclare #127
Comments
Jumping in to report that the same is valid for See v4 release notes here: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.0.0 |
I still had issues with this when using create react app. The issues went away after downgrading both this package and typescript. If this helps anyone out there getting stuck on this until every package is updated with the same workaround, it helped me to do the following: First remove your node_modules. (
Then, install previous version of this package:
NOTE: this is not a fix. This is a workaround while waiting for react-scripts to release their fix. They are aware of the problem. If you want to track it, here is the issue: facebook/create-react-app#9515 |
@typescript-eslint
v4 adds these new rules:This is required since the base rules report false positives in TypeScript (e.g.
no-shadow
reports enums) with the v4 typescript-eslint release (due to breaking changes in the scope analysis engine).no-shadow
rule should be turned off and replaced with@typescript-eslint/no-shadow
no-redeclare
rule should be turned off and replaced with@typescript-eslint/no-redeclare
The text was updated successfully, but these errors were encountered: